GH-8586: Deprecate IntegrationComponentSpec.get() #8594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#8586 The `IntegrationComponentSpec` is not a plain wrapper around single component. Sometimes it comes with several components where all of them must be registered as beans. If `IntegrationComponentSpec.get()` is called from end-user code, we may lose other related components, for example filters in the `FileInboundChannelAdapterSpec`. * Deprecate `IntegrationComponentSpec.get()` with no-op for end-user, rather encourage to leave it as is and let the framework take care about its lifecycle and related components registration * Fix `IntegrationComponentSpec` logic to deal as a simple `FactoryBean` instead of extra overhead via `AbstractFactoryBean` * Use `IntegrationComponentSpec.getObject()` in the framework code where `get()` was called * Fix tests to expose `IntegrationComponentSpec` as beans instead of previously called `get()` * Some other clean up and typos fixes in the affected classes * Document the change
garyrussell
suggested changes
Apr 12, 2023
...gration-core/src/main/java/org/springframework/integration/dsl/IntegrationComponentSpec.java
Show resolved
Hide resolved
…ComponentsToRegister()`
Co-authored-by: Gary Russell <[email protected]>
garyrussell
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8586
The
IntegrationComponentSpecis not a plain wrapper around single component. Sometimes it comes with several components where all of them must be registered as beans.If
IntegrationComponentSpec.get()is called from end-user code, we may lose other related components, for example filters in theFileInboundChannelAdapterSpec.IntegrationComponentSpec.get()with no-op for end-user, rather encourage to leave it as is and let the framework take care about its lifecycle and related components registrationIntegrationComponentSpeclogic to deal as a simpleFactoryBeaninstead of extra overhead viaAbstractFactoryBeanIntegrationComponentSpec.getObject()in the framework code whereget()was calledIntegrationComponentSpecas beans instead of previously calledget()