Expose more reflection hints #3951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bring back `@Reflective` on `Pausable` - for possible end-user usage * Add `ReactiveMessageHandler` hint since its method is used reflectively in the `IntegrationRSocketMessageHandler` * Add `@Reflective` on the `ServerRSocketMessageHandler.handleConnectionSetup()` since it is used reflectively for a `registerHandlerMethod()` * Add `KafkaRuntimeHints` to expose `Pausable` contract on Kafka inbound endpoints for SpEL invocation via Control Bus * Document native images support
garyrussell
suggested changes
Nov 18, 2022
| * | ||
| * @since 6.0 | ||
| */ | ||
| class KafkaRuntimeHints implements RuntimeHintsRegistrar { |
There was a problem hiding this comment.
Maybe rename to KafkaIntegrationRuntimeHints to avoid using the same class name?
There was a problem hiding this comment.
Was thinking about, but there is a package in a class name either way.
Plus this one is public as any library RuntimeHintsRegistrar impls registered in the aot.factories file.
See other Spring Integration impls: HttpRuntimeHints, JdbcRuntimeHints etc.
I really decided that integration in a name is going to be redundant if we have it already in a package name, plus this one is not public API to be used from end-user perspective.
Co-authored-by: Gary Russell <[email protected]>
garyrussell
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ReflectiveonPausable- for possible end-user usageReactiveMessageHandlerhint since its method is used reflectively in theIntegrationRSocketMessageHandler@Reflectiveon theServerRSocketMessageHandler.handleConnectionSetup()since it is used reflectively for aregisterHandlerMethod()KafkaRuntimeHintsto exposePausablecontract on Kafka inbound endpoints for SpEL invocation via Control Bus