GH-3421: Resolve throws Exception; in the API
#3916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3421 Remove `throws Exception;` from production code to honor the rule `Generic exceptions should never be thrown` which is enabled on SonarQube * Rework affected usages to `try..catch` with throwing respective runtime exception or just logging * Some other refactoring for the affected classes
garyrussell
suggested changes
Oct 17, 2022
...n/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/mail/transformer/MailToStringTransformer.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
Show resolved
Hide resolved
garyrussell
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3421
Remove
throws Exception;from production code to honor the ruleGeneric exceptions should never be thrownwhich is enabled on SonarQubetry..catchwith throwing respective runtime exception or just logging