GH-3635: Add Future<Void> & Mono<Void> to gateway #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Oct 3, 2022
src/reference/asciidoc/gateway.adoc
Outdated
| @@ -801,7 +800,9 @@ public interface MyGateway { | |||
| ---- | |||
| ==== | |||
|
|
|||
| Unlike the `Future<?>` return types, there is no way to inform the caller if some exception is thrown by the flow, unless some custom `TaskExecutor` (such as an `ErrorHandlingTaskExecutor`) is associated with the `@Async` annotation. | |||
| But downstream exceptions are not going to be propagated back to the caller. | |||
| To ensure asynchronous behaviour for downstream flow invocation and exception propagation to the caller, starting with version 6.0, the framework provides support for the `Future<Void>` and `Mono<Void>` return types. | |||
There was a problem hiding this comment.
American English (behavior).
Fixes spring-projects#3635 When `Future<Void>` & `Mono<Void>` is used as a messaging gateway return type, the application hangs out on this barrier which may lead to the out of memory eventually * Add support for the `Future<Void>` & `Mono<Void>` messaging gateway return type and ensure an asynchronous call for the `gateway.send(Message)` operation and its exception handling. In case of successful call, the `Future` is fulfilled with `null` and `Mono` is completed as empty
garyrussell
suggested changes
Oct 4, 2022
...ntegration-core/src/test/java/org/springframework/integration/gateway/AsyncGatewayTests.java
Show resolved
Hide resolved
…block in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3635
When
Future<Void>&Mono<Void>is used as a messaging gateway return type, the application hangs out on this barrier which may lead to the out of memory eventuallyFuture<Void>&Mono<Void>messaging gateway return type and ensure an asynchronous call for thegateway.send(Message)operation and its exception handling.In case of successful call, the
Futureis fulfilled withnullandMonois completed as empty