GH-3626: RabbitMQ Stream Support #3895
Conversation
Resolves spring-projects#3626 - spec for stream listener container - move message handler from scst to here; add spec
spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/Amqp.java
Outdated
Show resolved
Hide resolved
spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/Amqp.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/integration/amqp/dsl/RabbitInboundChannelAdapterSLCSpec.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/integration/amqp/dsl/RabbitInboundChannelAdapterSLCSpec.java
Outdated
Show resolved
Hide resolved
...p/src/main/java/org/springframework/integration/amqp/dsl/RabbitStreamMessageHandlerSpec.java
Outdated
Show resolved
Hide resolved
...p/src/main/java/org/springframework/integration/amqp/dsl/RabbitStreamMessageHandlerSpec.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/amqp/outbound/RabbitStreamMessageHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/amqp/outbound/RabbitStreamMessageHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/amqp/outbound/RabbitStreamMessageHandler.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @author Chris Bono | ||
| */ | ||
| public final class RabbitTestContainer { |
There was a problem hiding this comment.
See MySqlContainerTest, MongoDbContainerTest, MosquittoContainerTest etc.
I really prefer to have them as interfaces.
And no any IMAGE_CACHE, please.
There was a problem hiding this comment.
Why no IMAGE_CACHE? I think we need that for Bamboo; no?
There was a problem hiding this comment.
No, we don't. The Harbor is used by default from its Docker environment on Bamboo.
It might be different on Jenkins and so, but I indeed sure that we have a proper mirroring on Bamboo.
In fact I removed those extra ENV vars from Spring AMQP CI plan to realign it with whatever works for me in Spring Integration plans.
garyrussell
force-pushed
the
GH-3626
branch
from
c7696c1 to
22bcc3b
Compare
| @@ -44,7 +45,7 @@ | |||
| * @since 6.0 | |||
| * | |||
| */ | |||
| public class RabbitStreamMessageHandler extends AbstractMessageHandler implements Lifecycle { | |||
| public class RabbitStreamMessageHandler extends AbstractMessageProducingHandler { | |||
There was a problem hiding this comment.
Why is that? What do we produce from here?
| === RabbitMQ Changes | ||
|
|
||
| The AMQP module has been enhanced to provide support for inbound and outbound channel adapters using RabbitMQ Stream Queues. | ||
| See <<./amqp.adocrmq-streams>> for more information. |
There was a problem hiding this comment.
Cannot we move this up to the New Components section?
These are really new features even if in the existing module
garyrussell
force-pushed
the
GH-3626
branch
from
272efdd to
ca339b0
Compare
|
|
|
Ignore that last message - the change is needed in SCSt. |
Resolves #3626