GH-3839: Migrate MongoDB tests to Testcontainers #3852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projects#3839 * Create a new base interface for Mongo container-based tests * Migrate all tests to JUnit5 * Remove obsolete classes related to JUnit4 Mongo rule * Fix code style & readability here and there, a few Sonar issues * Fix failing test `validateWithConfiguredPollerFlow` * * This test was failing with Mongo error `$and/$or/$nor must be a nonempty array`. The cause was too small polling ratio of the update query, the consecutive read queries failed as no 'Oleg' document was in collection after ~100 ms.
artembilan
requested changes
Jul 18, 2022
...tion-mongodb/src/test/java/org/springframework/integration/mongodb/MongoDbContainerTest.java
Show resolved
Hide resolved
...tion-mongodb/src/test/java/org/springframework/integration/mongodb/MongoDbContainerTest.java
Outdated
Show resolved
Hide resolved
...tion-mongodb/src/test/java/org/springframework/integration/mongodb/MongoDbContainerTest.java
Outdated
Show resolved
Hide resolved
...tion-mongodb/src/test/java/org/springframework/integration/mongodb/MongoDbContainerTest.java
Outdated
Show resolved
Hide resolved
...tion-mongodb/src/test/java/org/springframework/integration/mongodb/MongoDbContainerTest.java
Show resolved
Hide resolved
...springframework/integration/mongodb/store/MongoDbMessageStoreClaimCheckIntegrationTests.java
Show resolved
Hide resolved
.../org/springframework/integration/mongodb/store/DelayerHandlerRescheduleIntegrationTests.java
Show resolved
Hide resolved
...egration-mongodb/src/test/java/org/springframework/integration/mongodb/dsl/MongoDbTests.java
Outdated
Show resolved
Hide resolved
...egration-mongodb/src/test/java/org/springframework/integration/mongodb/dsl/MongoDbTests.java
Outdated
Show resolved
Hide resolved
Closes spring-projects#3839 Couple of changes after the pull request review: * Get back the blank lines in test classes * Get back the blank lines for some inner classes * Eliminate bad renaming consequences * Remove a couple of garbage todos * Couple of places with code cleanup
artembilan
approved these changes
Jul 19, 2022
|
Merged as 50769d0 @oxcafedead , thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3839
validateWithConfiguredPollerFlow$and/$or/$nor must be a nonempty array. The cause was too smallpolling ratio of the update query, the consecutive read queries
failed as no 'Oleg' document was in collection after ~100 ms.