Skip to content

GH-3822 Allow MQTTv5 reconnection, even when first connection fails #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

kroutal
Copy link

@kroutal kroutal commented Jun 9, 2022

GH-3822: Allow MQTTv5 reconnection, even when first connection fails

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some Checktyle violations:

 Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mqtt/src/main/java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java:168:17: '}' at column 3 should be alone on a line. [RightCurly]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mqtt/src/main/java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java:172:33: '}' at column 5 should be alone on a line. [RightCurly]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mqtt/src/main/java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java:175:25: '}' at column 4 should be alone on a line. [RightCurly]
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-mqtt/src/main/java/org/springframework/integration/mqtt/outbound/Mqttv5PahoMessageHandler.java:176:25: '}' at column 4 should be alone on a line. [RightCurly]

Please, run this command locally ./gradlew clean :spring-integration-mqtt:check

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my further review.

Thank you!

@artembilan
Copy link
Member

Merged as 8cf5f90 and cherry-picked to 5.5.x after some clean up and minor tests & docs improvements.

@kroutal ,

thank you very much for the contribution; looking forward for more!

@artembilan artembilan closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants