GH-3794: Use less memory with scheduled tasks #3796
Conversation
|
I'm not sure how to test this therefore I just leave it as is with the conclusion that nothing is broken and that's it. |
|
Not really a memory leak, right? Actually "Reduce Memory Usage with Scheduled Tasks"? |
|
Well, @vfunshteyn-zw called it a "memory leak" because their groups were scheduled for 72 hours. Anyway: we can call it whatever, but better to let GC to do its job and leave the memory for other purposes. |
|
Right; I was just concerned that someone browses the change log. A leak is specifically when some memory is allocated but never released. In this case, it's unnecessary memory usage that is eventually removed. I am ok with merging as-is, though, if you like. |
|
I see. Let me change that commit message then! Thank you! |
Fixes spring-projects#3794 * Replace hard reference to message group with its `id` in the `AbstractCorrelatingMessageHandler.removeEmptyGroupAfterTimeout()` * Replace hard reference to message with its `id` in the `DelayHandler.rescheduleAt()` **Cherry-pick to `5.5.x`**
artembilan
changed the title
|
Fixed |
|
...and cherry-picked. |
Fixes #3794
idin theAbstractCorrelatingMessageHandler.removeEmptyGroupAfterTimeout()idin theDelayHandler.rescheduleAt()Cherry-pick to
5.5.x