Skip to content

GH-2708: Make messaging annotations as repeatable #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

artembilan
Copy link
Member

Fixes #2708

There are some requests to use the same service method for different input channels

  • Make all the messaging annotations as @Repeatable with their
    respective container annotations
  • Modify MessagingAnnotationPostProcessor logic to deal with the mentioned repeatable
    requirements

Fixes spring-projects#2708

There are some requests to use the same service method for different input channels

* Make all the messaging annotations as `@Repeatable` with their
respective container annotations
* Modify `MessagingAnnotationPostProcessor` logic to deal with the mentioned repeatable
requirements
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

@@ -301,7 +301,7 @@ public class ThingService {
----
====

You can also use the `@Headers` annotation to provide all of the message headers as a `Map`, as the following example shows:
You can also use the `@Headers` annotation to provide all the message headers as a `Map`, as the following example shows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English was correct.

Suggested change
You can also use the `@Headers` annotation to provide all the message headers as a `Map`, as the following example shows:
You can also use the `@Headers` annotation to provide all of the message headers as a `Map`, as the following example shows:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancel that: https://jakubmarian.com/is-it-all-the-or-all-of-the-in-english/

correct All the people I know were there.
correctAll of the people I know were there. (see below)
Having said that, the variant without “of” is significantly more common than the variant with “of”, to such a degree that the variant with “of” might be considered unnatural

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, Gary.
Just followed IDEA suggestion:
image
And here is some article discussing such a matter: https://jakubmarian.com/is-it-all-the-or-all-of-the-in-english/

Do you have arguments against? 😄
Because I really sometimes blindly follow whatever my IDE suggests...

Thanks

@garyrussell garyrussell merged commit 97ab596 into spring-projects:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Multi-input Bridge
2 participants