GH-3615: Make log() as non-terminal in DSL #3769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3615 The `log()` operator for Java DSL in the end of flow causes a confusion for its different behavior and, therefore, inconsistency with expectations * Populate a `bridge()` in the end of flow instead of `nullChannel` when the current component is `WireTapSpec` (relevant to `wireTap()` and `log()`) * Deprecate a `logAndReply()` operator since its behavior is now included into the `log()` in the end if flow * Fix tests to use just `log()` in the end from now on * Fix `dsl.adoc` for the new `log()` behaviour in the end of flow
garyrussell
approved these changes
Apr 7, 2022
|
I polished the migration guide a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3615
The
log()operator for Java DSL in the end of flow causes a confusionfor its different behavior and, therefore, inconsistency with expectations
bridge()in the end of flow instead ofnullChannelwhenthe current component is
WireTapSpec(relevant towireTap()andlog())logAndReply()operator since its behavior is now included into thelog()in the end if flowlog()in the end from now ondsl.adocfor the newlog()behaviour in the end of flow