GH-3735: Don't mutate FeedEntryMS metadataKey #3754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3735 The `FeedEntryMessageSource` adds an url to the provided `metadataKey` making it incompatible when we provide a `Resource`-based configuration. * Remove adding of the url to the `metadataKey` making it rely only on the provided value * Remove internal `Comparator` for entries in favor of `Comparator.comparing()` feature * Improve some internal logic of the `PropertiesPersistingMetadataStore` when it emits a false warning: cannot create dirs, but they are present * Improve `feed.adoc`
garyrussell
suggested changes
Mar 22, 2022
|
Correct. See this first: #3756 |
garyrussell
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3735
The
FeedEntryMessageSourceadds an url to the providedmetadataKeymaking it incompatible when we provide a
Resource-based configuration.metadataKeymaking it rely onlyon the provided value
Comparatorfor entries in favor ofComparator.comparing()feature
PropertiesPersistingMetadataStorewhen it emits a false warning: cannot create dirs, but they are present
feed.adoc