-
Notifications
You must be signed in to change notification settings - Fork 1.1k
GH-3661: Resolve Spring Apache Kafka Deprecations #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...java/org/springframework/integration/kafka/inbound/KafkaErrorSendingMessageRecoverer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Copyright 2022 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.integration.kafka.inbound; | ||
|
||
import org.apache.kafka.clients.consumer.ConsumerRecord; | ||
|
||
import org.springframework.core.AttributeAccessor; | ||
import org.springframework.integration.core.ErrorMessagePublisher; | ||
import org.springframework.integration.kafka.support.RawRecordHeaderErrorMessageStrategy; | ||
import org.springframework.integration.support.ErrorMessageStrategy; | ||
import org.springframework.integration.support.ErrorMessageUtils; | ||
import org.springframework.kafka.listener.ConsumerRecordRecoverer; | ||
import org.springframework.kafka.support.KafkaHeaders; | ||
import org.springframework.messaging.MessageChannel; | ||
|
||
/** | ||
* An extension of {@link ErrorMessagePublisher} that can be used in a | ||
* {@link org.springframework.kafka.listener.CommonErrorHandler} for recovering Kafka | ||
* delivery failures. | ||
* | ||
* @author Gary Russell | ||
* @since 6.0 | ||
* | ||
*/ | ||
public class KafkaErrorSendingMessageRecoverer extends ErrorMessagePublisher implements ConsumerRecordRecoverer { | ||
|
||
/** | ||
* Construct an instance to send to the channel with the | ||
* {@link RawRecordHeaderErrorMessageStrategy}. | ||
* @param channel the channel. | ||
*/ | ||
public KafkaErrorSendingMessageRecoverer(MessageChannel channel) { | ||
this(channel, new RawRecordHeaderErrorMessageStrategy()); | ||
} | ||
|
||
/** | ||
* Construct an instance to send the channel, using the error message strategy. | ||
* @param channel the channel. | ||
* @param errorMessageStrategy the strategy. | ||
*/ | ||
public KafkaErrorSendingMessageRecoverer(MessageChannel channel, ErrorMessageStrategy errorMessageStrategy) { | ||
setChannel(channel); | ||
setErrorMessageStrategy(errorMessageStrategy); | ||
} | ||
|
||
@Override | ||
public void accept(ConsumerRecord<?, ?> record, Exception ex) { | ||
Throwable thrown = ex.getCause(); | ||
if (thrown == null) { | ||
thrown = ex; | ||
} | ||
AttributeAccessor attrs = ErrorMessageUtils.getAttributeAccessor(null, null); | ||
attrs.setAttribute(KafkaHeaders.RAW_DATA, record); | ||
publish(thrown, attrs); | ||
} | ||
|
||
} |
79 changes: 79 additions & 0 deletions
79
...fka/src/main/java/org/springframework/integration/kafka/inbound/KafkaInboundEndpoint.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* | ||
* Copyright 2022 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.integration.kafka.inbound; | ||
|
||
import org.apache.kafka.clients.consumer.Consumer; | ||
|
||
import org.springframework.kafka.KafkaException; | ||
import org.springframework.kafka.support.Acknowledgment; | ||
import org.springframework.retry.RecoveryCallback; | ||
import org.springframework.retry.support.RetryTemplate; | ||
|
||
/** | ||
* Implementations of this interface will generally support a retry template for retrying | ||
* incoming deliveries and this supports adding common attributes to the retry context. | ||
* | ||
* @author Gary Russell | ||
* @since 6.0 | ||
* | ||
*/ | ||
public interface KafkaInboundEndpoint { | ||
|
||
/** | ||
* {@link org.springframework.retry.RetryContext} attribute key for an acknowledgment | ||
* if the listener is capable of acknowledging. | ||
*/ | ||
String CONTEXT_ACKNOWLEDGMENT = "acknowledgment"; | ||
|
||
/** | ||
* {@link org.springframework.retry.RetryContext} attribute key for the consumer if | ||
* the listener is consumer-aware. | ||
*/ | ||
String CONTEXT_CONSUMER = "consumer"; | ||
|
||
/** | ||
* {@link org.springframework.retry.RetryContext} attribute key for the record. | ||
*/ | ||
String CONTEXT_RECORD = "record"; | ||
|
||
/** | ||
* Execute the runnable with the retry template and recovery callback. | ||
* @param template the template. | ||
* @param callback the callback. | ||
* @param record the record (or records). | ||
* @param acknowledgment the acknowledgment. | ||
* @param consumer the consumer. | ||
* @param runnable the runnable. | ||
*/ | ||
default void doWithRetry(RetryTemplate template, RecoveryCallback<?> callback, Object data, | ||
Acknowledgment acknowledgment, Consumer<?, ?> consumer, Runnable runnable) { | ||
|
||
try { | ||
template.execute(context -> { | ||
context.setAttribute(CONTEXT_RECORD, data); | ||
context.setAttribute(CONTEXT_ACKNOWLEDGMENT, acknowledgment); | ||
context.setAttribute(CONTEXT_CONSUMER, consumer); | ||
runnable.run(); | ||
return null; | ||
}, callback); | ||
} | ||
catch (Exception ex) { | ||
throw new KafkaException("Failed to execute runnable", ex); | ||
} | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any general JavaDoc, please?