Skip to content

Documentation fix for 'Message Channels with Hazelcast' #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KaVeKa opened this issue Jun 11, 2024 · 1 comment · Fixed by #9231
Closed

Documentation fix for 'Message Channels with Hazelcast' #9230

KaVeKa opened this issue Jun 11, 2024 · 1 comment · Fixed by #9231

Comments

@KaVeKa
Copy link
Contributor

KaVeKa commented Jun 11, 2024

Expected Behavior

The code snippet in the hazelcast.adoc documentation (section Message Channels with Hazelcast) should provide the correct way of instantiating the QueueChannel.

@Bean
PollableChannel hazelcastQueueChannel(HazelcastInstance hazelcastInstance) {
    return new QueueChannel(hazelcastInstance.getQueue("springIntegrationQueue"));
}

Current Behavior

There is some code in the code snippet that should not be there. (Message<?>>)

@Bean
PollableChannel hazelcastQueueChannel(HazelcastInstance hazelcastInstance) {
    return new QueueChannel(hazelcastInstance.Message<?>>getQueue("springIntegrationQueue"));
}

Context
By looking at the documentation and deciding which message channel approach I would be using, I found this code snippet to be weird-looking and seemingly incorrect.

@KaVeKa KaVeKa added status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement labels Jun 11, 2024
@KaVeKa KaVeKa closed this as completed Jun 11, 2024
@KaVeKa KaVeKa reopened this Jun 11, 2024
@artembilan artembilan added this to the 6.4.0-M1 milestone Jun 11, 2024
@artembilan artembilan added type: documentation and removed type: enhancement status: waiting-for-triage The issue need to be evaluated and its future decided labels Jun 11, 2024
@artembilan
Copy link
Member

Fee free to contribute such a fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc.

Thank you!

artembilan pushed a commit that referenced this issue Jun 12, 2024
Fixes: #9230

Some code was present in the code snippet that shouldn't be there.


**Auto-cherry-pick to `6.3.x` & `6.2.x`**
spring-builds pushed a commit that referenced this issue Jun 12, 2024
Fixes: #9230

Some code was present in the code snippet that shouldn't be there.

(cherry picked from commit 3d66ea0)
spring-builds pushed a commit that referenced this issue Jun 12, 2024
Fixes: #9230

Some code was present in the code snippet that shouldn't be there.

(cherry picked from commit 3d66ea0)
EddieChoCho pushed a commit to EddieChoCho/spring-integration that referenced this issue Jun 26, 2024
Fixes: spring-projects#9230

Some code was present in the code snippet that shouldn't be there.


**Auto-cherry-pick to `6.3.x` & `6.2.x`**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants