Skip to content

Rework JavaScript support to GraalVM #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artembilan opened this issue Nov 7, 2021 · 0 comments · Fixed by #3911
Closed

Rework JavaScript support to GraalVM #3664

artembilan opened this issue Nov 7, 2021 · 0 comments · Fixed by #3911
Labels
in: scripting type: enhancement
Milestone
6.0.0-RC1

Comments

@artembilan
Copy link
Member

See more info in GraalVM: https://www.graalvm.org/reference-manual/js/JavaInteroperability/.

It may turn out just to a simple GraalVmJavaScriptExecutor implementation since making it working we need to expose these variables:

<script:variable name="polyglot.js.allowHostAccess" value="#{true}"/>
<script:variable name="polyglot.js.allowHostClassLookup" value="#{true}"/>

For now JavaScript tests are disable if no GraalVM in classpath.
@artembilan artembilan added this to the 6.0.x milestone Nov 7, 2021
artembilan added a commit to artembilan/spring-integration that referenced this issue Oct 11, 2022
@artembilan
spring-projectsGH-3664: Re-enable JavaScript support via GraalVM
c7813d3 
Fixes spring-projects#3664

The JavaScript JSR223 engine has been removed from Java.

Migrate JavaScript support into GraalVM Polyglot API:
* Implement `PolyglotScriptExecutor` which can also support other GraalVM languages
* Change the `ScriptExecutorFactory` to use a `PolyglotScriptExecutor` when it encounters JavaScript
* Re-enable tests for JavaScript
* Add GraalVM Polyglot support into docs
@artembilan artembilan modified the milestones: 6.0.x, 6.0.0-RC1 Oct 11, 2022
@artembilan artembilan mentioned this issue Oct 11, 2022
Merged
artembilan added a commit to artembilan/spring-integration that referenced this issue Oct 11, 2022
@artembilan
spring-projectsGH-3664: Re-enable JavaScript support via GraalVM
0e3fff3 
Fixes spring-projects#3664

The JavaScript JSR223 engine has been removed from Java.

Migrate JavaScript support into GraalVM Polyglot API:
* Implement `PolyglotScriptExecutor` which can also support other GraalVM languages
* Change the `ScriptExecutorFactory` to use a `PolyglotScriptExecutor` when it encounters JavaScript
* Re-enable tests for JavaScript
* Add GraalVM Polyglot support into docs
garyrussell pushed a commit that referenced this issue Oct 11, 2022
@artembilan
GH-3664: Re-enable JavaScript support via GraalVM (#3911)
6641b1f 
* GH-3664: Re-enable JavaScript support via GraalVM

Fixes #3664

The JavaScript JSR223 engine has been removed from Java.

Migrate JavaScript support into GraalVM Polyglot API:
* Implement `PolyglotScriptExecutor` which can also support other GraalVM languages
* Change the `ScriptExecutorFactory` to use a `PolyglotScriptExecutor` when it encounters JavaScript
* Re-enable tests for JavaScript
* Add GraalVM Polyglot support into docs

* * Reinstate `@EnabledIfSystemProperty` for GraalVM JS system property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: scripting type: enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-3664: Re-enable JavaScript support via GraalVM artembilan/spring-integration
1 participant
@artembilan