Unable to configure error message strategy for JMS channel adapters and gateways

[matthera]

In what version(s) of Spring Integration are you seeing this issue?

2.0.4.RELEASE -> LATEST (currently 6.5.0-RC1)

Describe the bug

The ChannelPublishingJmsMessageListener fails to proxy the setErrorMessageStrategy/getErrorMessageStrategy methods on its internal GatewayDelegate. This makes setting the error message strategy for message driven JMS channel adapters and gateways impossible.

To Reproduce

1. Call the 'setErrorMessageStrategy' method on ChannelPublishingJmsMessageListener.
2. Notice the code compilation error.

Expected behavior

The ChannelPublishingJmsMessageListener should proxy the setErrorMessageStrategy/getErrorMessageStrategy methods on its internal GatewayDelegate.

Sample

n/a

[mjd507]

    @Bean
    public IntegrationFlow jmsMessageDrivenFlow(ConnectionFactory connectionFactory) {
        return IntegrationFlow.from(
                        Jms.messageDrivenChannelAdapter(connectionFactory)
                                .errorMessageStrategy(new DefaultErrorMessageStrategy())
                                .destination(queue)
                                .id("observedJmsIntegrationQueue")
                )
                .handle(msg -> logger.info(msg))
                .get();
    }

looks in my local no compilation error in Java DSL way.

[matthera]

It was more the non-DSL java configuration I was referencing regarding the compilation error.

However, does the DSL configuration actually work? I don't fully understand how the DSL configuration applies, but from what I can see it calls the setErrorMessageStrategy method on the JmsMessageDrivenEndpoint. Similarly, the JmsMessageDrivenEndpoint proxies all the get/set method to the internal listener (ChannelPublishingJmsMessageListener), except the setErrorMessageStrategy/getErrorMessageStrategy. So surely the error message strategy will just be set on JmsMessageDrivenEndpoint, which is ignored from a functionality point of view?

[mjd507]

thank you, I understand your point now.
you want to propagate the ErrorMessageStrategy from JmsMessageDrivenEndpoint to its internal ChannelPublishingJmsMessageListener , since the listener internally uses a GatewayDelegate with default JmsMessageHeaderErrorMessageStrategy , and you have no way to change the strategy with your own.

[artembilan]

There cannot be a compilation error because of JmsMessageDrivenEndpoint extends MessageProducerSupport.
So, we can do:

		@Bean
		public JmsMessageDrivenEndpoint inbound() {
			JmsMessageDrivenEndpoint jmsMessageDrivenEndpoint = new JmsMessageDrivenEndpoint(container(), listener());
			jmsMessageDrivenEndpoint.setErrorMessageStrategy(new DefaultErrorMessageStrategy());
			return jmsMessageDrivenEndpoint;
		}

However, I definitely see the problem.

public class JmsMessageDrivenEndpoint extends MessageProducerSupport implements OrderlyShutdownCapable {

	private final ChannelPublishingJmsMessageListener listener;

Where that ChannelPublishingJmsMessageListener has:

private final GatewayDelegate gatewayDelegate = new GatewayDelegate();

Which is the central part to perform all the hard work.
And indeed, the provided ErrorMessageStrategy has to be propagated down here, like we do for many other MessageProducerSupport options.

Your proxy word has confused me originally.

[matthera]

Great - thanks for such a quick turn-around on this one. Really appreciate it.