Skip to content

Add support for heic and heif mime types #34657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yotam2010
Copy link

Add additional mime types to not default to application/octet-stream

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 26, 2025
@bclozel
Copy link
Member

bclozel commented Mar 26, 2025

I'm not sure we should merge this PR.
We usually keep this file in sync with Tomcat's defaults and it doesn't seem to refer to heic/heif, even if those are quite popular.

@yotam2010
Copy link
Author

I'm not sure we should merge this PR. We usually keep this file in sync with Tomcat's defaults and it doesn't seem to refer to heic/heif, even if those are quite popular.

Just looked why its not supported on Tomcat, and it seems that it is also not supported on browsers which is ultimately where I want to display it, so i guess we dont need it for our project anyhow.

Will just need to convert it.

Let me know if I should close this PR or if you still considering :)

@bclozel bclozel closed this Mar 26, 2025
@bclozel
Copy link
Member

bclozel commented Mar 26, 2025

Thanks. We'll keep aligning with what Tomcat does

@jhoeller jhoeller added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants