Simplify implementation of FilteredIterator
#33902
Closed
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KNU-K Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@KNU-K Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: task
sbrannen
changed the title
FilteredIterator
sbrannen
added a commit
that referenced
this pull request
Nov 17, 2024
|
@sbrannen |
Yes, it has. Please note, however, that there is no need to ask that. You can see that yourself by looking at the "events" in the issue, for example: #33902 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, there are unnecessary 'else' phrases and if phrases.
This can be good in terms of readability, but deepening depth can actually be out of sight.
That's why I modified the same format to be used a little more concisely.