Add test coverage for DomUtils #33768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
snicoll
pushed a commit
that referenced
this pull request
Nov 3, 2024
snicoll
added a commit
that referenced
this pull request
Nov 3, 2024
snicoll
added
type: task
|
@kunaljani1100 thanks for your contribution. Please see d431267 for the polish commit. Going back to our previous discussion, unsolicited PRs (i.e. without an issue first to discuss the change) is OK but, as a small team, it needs to be in a good state and I am afraid we're not in a capacity right now to do the back and forth to reach that, which is why I polished it directly. Running the build would have revealed that JUnit assertions is not ok (or look at other tests if you need some inspiration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests have been added for the
DomUtilsclass to test whether all the functions in this class work according to their expected behavior. Since testing for this class was not present tests have been added for this class.In PR #33752, testing of
DomUtilswas done using Mocked objects, a modification has been done. Tests have loaded small XML files from the test classpath and assertion has been done on the actualElement.