Consistently use CharSequence.isEmpty() for emptiness checks
#33577
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
isEmpty() for String type insteadString.isEmpty() for String length checks
| @@ -117,7 +117,7 @@ public int getStepArgument(final int index) { | |||
| * @return the corresponding TypePath object, or {@literal null} if the path is empty. | |||
| */ | |||
| public static TypePath fromString(final String typePath) { | |||
| if (typePath == null || typePath.length() == 0) { | |||
| if (typePath == null || typePath.isEmpty()) { | |||
There was a problem hiding this comment.
Please refrain from modifying classes under org.springframework.asm and org.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
Note, however, that we can revert this change manually if we decide to merge this PR.
There was a problem hiding this comment.
I think I should revert files in org.springframework.asm and org.springframework.objenesis to prevent any unexpected exception related third-party
sbrannen
added
in: core
sbrannen
changed the title
String.isEmpty() for String length checksCharSequence.isEmpty() for emptiness checks
|
This has been merged into Thanks p.s. please note that I updated the copyright dates accordingly. |
No description provided.