Skip to content

Fix predicate setup in test #33368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tafjwr
Copy link
Contributor

@tafjwr tafjwr commented Aug 12, 2024

Predicate#and() composes the predicate as its return value, so now, the and clauses are ignored at the assertion.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 12, 2024
@tafjwr tafjwr force-pushed the fix-predicate-setup-for-test-assertion branch from 74aacaa to 04476f4 Compare August 12, 2024 06:27
@tafjwr tafjwr force-pushed the fix-predicate-setup-for-test-assertion branch from 04476f4 to 2225404 Compare August 12, 2024 06:29
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 12, 2024
@snicoll snicoll self-assigned this Aug 12, 2024
@snicoll snicoll added this to the 6.1.12 milestone Aug 12, 2024
@snicoll snicoll changed the title Fix predicate setup for test assertion Fix predicate setup in test Aug 12, 2024
snicoll pushed a commit that referenced this pull request Aug 12, 2024
snicoll added a commit that referenced this pull request Aug 12, 2024
@snicoll snicoll closed this in 289c35c Aug 12, 2024
@snicoll
Copy link
Member

snicoll commented Aug 12, 2024

Thanks @tafjwr - I've reworked the tests so that we don't use any predicate at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants