Skip to content

Add a way to set the timeout to reactive jdk client #32941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

m4tt30c91
Copy link
Contributor

Add a setTimeout method to the http reactive jdk native connector

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 3, 2024
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jun 3, 2024
@jhoeller
Copy link
Contributor

jhoeller commented Jun 6, 2024

Thanks for the suggestion! We should name that method setReadTimeout, aligned with JdkClientHttpRequestFactory, and possibly pass the Duration straight into an extended JdkClientHttpRequest constructor (since the request class is not public anyway, we can flexibly change the constructor signature to accept a Duration parameter that we can directly apply there).

Feel free to revise the PR accordingly, otherwise we can also implement it directly.

@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 6, 2024
@jhoeller jhoeller added this to the 6.2.x milestone Jun 6, 2024
@m4tt30c91
Copy link
Contributor Author

Sure, gonna review the pull request accordingly; is it ok if I add a commit on top, or would you prefer a single one to keep it cleaner?

@snicoll
Copy link
Member

snicoll commented Jun 6, 2024

Both are fine but if you can squash that’s better.

Add a setReadTimeout method to the http reactive jdk native connector
@m4tt30c91 m4tt30c91 force-pushed the features/jdkclienthttprequest-timeout branch from 4f4f2c6 to a8eba89 Compare June 6, 2024 19:22
@m4tt30c91
Copy link
Contributor Author

I did review the pull request, let me know if that is ok.

@snicoll snicoll self-assigned this Jun 7, 2024
snicoll added a commit that referenced this pull request Jun 7, 2024
@snicoll snicoll closed this in 55a7a49 Jun 7, 2024
@snicoll snicoll modified the milestones: 6.2.x, 6.2.0-M4 Jun 7, 2024
@snicoll
Copy link
Member

snicoll commented Jun 7, 2024

Thanks for making your first contribution to Spring Framework, @m4tt30c91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants