introduce internal single value map handle for MultiValueMap #32853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@gdmrw thanks for the PR but both the issues you've referenced are already assigned to someone so they're working on it. You can share your thoughts on the issue but code change can't be accepted due to the assignment. |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #32826 and #32832 problem description and solution proposal, I introduce 2 static methods
ofMultiandofsingleintoMultiValueMap(LinkedMultiValueMap).Briefly, It simplifies the conversion of Map to LinkedMultiValueMap, enhancing code simplicity and consistency while maintaining backward compatibility.
Now you can use
LinkedMultiValueMap.ofSingle(map)to quickly transfer the normal single value map into a multivalue map which match theFormHttpMessageConverterinput requirement.The
toMultimethod seems useless because it will not need any work if you build a multivalue mao by default.These are a bit of my personal thinking and not sure if it is true.