Resolve property-dependent parameter names for exception messages #32462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit when a required parameter defined as a property or expression placeholder was missing, the exception thrown would refer to the placeholder instead of the resolved name. See spring-projectsgh-32323
Prior to this commit when a non-required parameter defined as a property or expression placeholder was missing and the value couldn't be returned as null due to its type being primitive, the exception thrown would refer to the placeholder instead of the resolved name. See spring-projectsgh-32323
…r message Prior to this commit when a required parameter with conversion defined as a property or expression placeholder was missing, the exception thrown would refer to the placeholder instead of the resolved name. See spring-projectsgh-32323
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: messaging
simonbasle
added
type: enhancement
simonbasle
suggested changes
Mar 18, 2024
…gValue and handleNullValue to improve error message Prior to this commit when an error occurred related to a property or expression placeholder, the exception thrown would refer to the placeholder instead of the resolved name. See spring-projectsgh-32323
|
@simonbasle The occurrence in |
simonbasle
approved these changes
Mar 20, 2024
simonbasle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When named value method arguments are defined through placeholders or SpeL and an exception is thrown because the required parameter is missing or can't be converted, the exception message references the placeholder instead of the resolved named value. Example:
This PR enhances the error message by passing the resolved parameter name to the error handlers, so that the exception thrown is more relevant.
Closes #32323