Support DispatcherType.INCLUDE in DefaultServletHttpRequestHandler #30113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving static resources by enabling the
DefaultServletHttpRequestHandler
you will get anIllegalStateException
(Response already commited) error when importing a static resource.I believe this is caused by the fact that
DefaultServletHttpRequestHandler.handleRequest(...)
is always callingRequestDispatcher.forward(...)
which will set the response to commited. If it were to check the dispatcher type and instead callRequestDispatcher.include(...)
when the dispatcher type of the request is set toDispatcherType.INCLUDE
, then everything works as expected.