Refactor AcceptHeaderLocaleResolver to implement LocaleContextResolver #29239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up efforts to improve
org.springframework.web.servlet.LocaleResolver
hierarchy started in:CookieLocaleResolver
to useResponseCookie
#28779The core change proposed here (first commit) is to refactor
AcceptHeaderLocaleResolver
to implementLocaleContextResolver
, which makes the all locale resolvers provided by Spring MVCLocaleContextResolver
based. It also aligns Spring MVC with Spring WebFlux, where all resolvers work withLocaleContext
rather than plainLocale
.The two subsequent commits are optional, but could be helpful as they prepare ground to simplifying
LocaleResolver
hierarchy in the future:AbstractLocaleResolver
in favor ofAbstractLocaleContextResolver
, as nothing is usingAbstractLocaleResolver
after the first commitorg.springframework.web.servlet.LocaleResolver
and reworks all the references to operate againstLocaleContextResolver
- while technically a breaking change, this only impacts those with customLocaleResolver
that don't implementLocaleContextResolver