Increase StreamUtils.BUFFER_SIZE to 8192 #28965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This aligns the buffer size used in StreamUtils with the buffer sizes used throughout the JDK (see InputStream, BufferedInputStream, Files).
|
FYI, it's also the buffer size used in Guava and Apache Commons. |
kilink
force-pushed
the
increase-stream-utils-buffer-size
branch
from
b6ea71b to
9c4e3df
Compare
kilink
commented
Aug 15, 2022
| @@ -83,7 +83,7 @@ public static String copyToString(@Nullable InputStream in, Charset charset) thr | |||
| return ""; | |||
| } | |||
|
|
|||
| StringBuilder out = new StringBuilder(BUFFER_SIZE); | |||
| StringBuilder out = new StringBuilder(); | |||
There was a problem hiding this comment.
My reasoning for using the default here, is that for any output less than BUFFER_SIZE, we end up over-allocating by specifying this value. If we use the default, and the first read fills the buffer, we will resize to BUFFER_SIZE immediately anyway when we write to the StringBuilder.
bclozel
added
in: core
|
Thanks for your first contribution @kilink , this will be in the next 6.0.0 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the buffer size used in StreamUtils with the buffer sized
used throughout the JDK (see InputStream, BufferedInputStream, Files).