Skip to content

Add minimal Kotlin DSL RouterFunction attributes support #28569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add minimal Kotlin DSL RouterFunction attributes support #28569

wants to merge 2 commits into from

Conversation

christophejan
Copy link
Contributor

Add minimal Kotlin DSL RouterFunction attributes support

Fixes #28567.

The PR is composed by 2 commits that are more easy to review one by one :

  1. Add test case on nested RouterFunction attributes : as nested route attributes are already supported but not clearly tested
  2. Add minimal Kotlin DSL RouterFunction attributes support : just minimal to ensure that minimal support will be quickly integrated ; I think better Kotlin integration could be done be should probably be discussed

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 5, 2022
@poutsma poutsma self-assigned this Jun 8, 2022
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement theme: kotlin An issue related to Kotlin support and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 8, 2022
@poutsma poutsma added this to the 6.0.0-M5 milestone Jun 8, 2022
poutsma added a commit that referenced this pull request Jun 8, 2022
@poutsma
Merge pull request #28569 from christophejan:fix/28567
283bc9e 
* gh-28567:
  Polish
  Add minimal Kotlin DSL RouterFunction attributes support
  Add test case on nested RouterFunction attributes
@poutsma
Copy link
Contributor

poutsma commented Jun 8, 2022 •
edited
Loading

This PR has been merged, see 283bc9e.

@christophejan Thank you for submitting a PR.

@poutsma poutsma closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M5
Development

Successfully merging this pull request may close these issues.

Introduce attribute support in Kotlin RouterFunction DSL
3 participants
@christophejan @poutsma @spring-projects-issues