Bean definition contribution includes attributes that are not used at… #28538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR. I don't think that removing the feature altogether is what we should aiming at. We're still discussing in the issue so we're not really ready to accept a contribution for this. Thanks anyway! |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This commit fixes issue #28516 by removing mechanism for adding attributes to dynamically compiled beans. I think that attributes in compiled beans are not relevant, so this solution may do the thing. Other solution may be implementing filter to automatically filter attributes with "PostProcessor" string in it as they are used internally and don't really contribute in runtime. What do you think?