SPR-7925 Introduce Assert.noNullElements for collections #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, org.springframework.util.Assert provided noNullElements-methods for arrays only. This commit unifies the available methods for arrays and collections by adding noNullElements-methods for collections. A method without message parameter was not added since the other methods without message parameter are deprecated. Issue: SPR-7925
|
PMD complains about missing asserts in the new tests. I just copied existing tests. Is there a better way to check that no exception was raised or is it okay for these tests to leave them without assert? |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in SPR-7925.
The issue also proposes a
noNullKeys(Map)andnoNullValues(Map). If this makes sense I would also implement it with this or a separate PR.