Skip to content

SpEL incorrectly splits string arguments by comma for Object... varargs method #33189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Jul 10, 2024 · 3 comments
Closed

SpEL incorrectly splits string arguments by comma for Object... varargs method #33189

github-actions bot opened this issue Jul 10, 2024 · 3 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply

Comments

@github-actions
Copy link
Contributor

Backport of gh-33013
@github-actions github-actions bot added in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Jul 10, 2024
@github-actions github-actions bot added this to the 6.0.23 milestone Jul 10, 2024
@sbrannen sbrannen self-assigned this Jul 10, 2024
sbrannen added a commit that referenced this issue Jul 26, 2024
@sbrannen
Support single String argument for varargs invocations in SpEL
d33f66d 
Prior to this commit, the Spring Expression Language (SpEL) incorrectly
split single String arguments by comma for Object... varargs method and
constructor invocations.

This commit addresses this by checking if the single argument type is
already "assignable" to the varargs component type instead of "equal"
to the varargs component type.

See gh-33013
Closes gh-33189
@github-actions GitHub Actions
Copy link
Contributor Author

Fixed via d33f66d

@sbrannen
Copy link
Member

sbrannen commented Aug 4, 2024

Due to #33315, we have decided to revert the backport of #33013 to 5.3.38 and 6.0.23.

@sbrannen sbrannen reopened this Aug 4, 2024
@sbrannen sbrannen added status: declined A suggestion or change that we don't feel we should currently apply and removed type: bug A general bug type: backport An issue that is a backport of another issue to a maintenance branch labels Aug 4, 2024
sbrannen added a commit that referenced this issue Aug 4, 2024
@sbrannen
Revert "Support single String argument for varargs invocations in SpEL"
e11a419 
This reverts commit d33f66d.

See gh-33013
See gh-33189
@sbrannen
Copy link
Member

sbrannen commented Aug 4, 2024

Reverted in commit e11a419.

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2024
@sbrannen sbrannen removed this from the 6.0.23 milestone Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbrannen