Skip to content

Deploy Docs Action should only run on production branches #32434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Mar 13, 2024 · 2 comments
Closed

Deploy Docs Action should only run on production branches #32434

snicoll opened this issue Mar 13, 2024 · 2 comments
Assignees
@snicoll
Labels
status: feedback-provided Feedback has been provided type: task A general task
Milestone
6.1.6

Comments

@snicoll
Copy link
Member

snicoll commented Mar 13, 2024

I've pushed a new branch on this repo for testing purposes and I could see that the action used to deploy the docs kicked off on it. It should only build our "production branches".
@snicoll snicoll added the type: task A general task label Mar 13, 2024
@snicoll snicoll added this to the 6.2.0-M1 milestone Mar 13, 2024
@snicoll snicoll changed the title Deploy Docs GitHub Action should only run on production branches Deploy Docs Action should only run on production branches Mar 13, 2024
@snicoll snicoll modified the milestones: 6.2.0-M1, 6.1.5 Mar 13, 2024
@snicoll snicoll added type: backport An issue that is a backport of another issue to a maintenance branch for: backport-to-6.0.x and removed type: backport An issue that is a backport of another issue to a maintenance branch labels Mar 13, 2024
@snicoll snicoll self-assigned this Mar 13, 2024
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.0.x labels Mar 13, 2024
@github-actions github-actions bot mentioned this issue Mar 13, 2024
Closed
@snicoll
Copy link
Member Author

snicoll commented Mar 13, 2024

@rwinch I was trying to figure this out but I can see that this action also runs on a tag (to build the doc for a release I assume). It's a bit strange that it kicks off for any branch (except the doc branch) and any tag. What am I missing?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 13, 2024
@snicoll snicoll modified the milestones: 6.1.5, 6.1.x Mar 14, 2024
@snicoll snicoll removed the status: backported An issue that has been backported to maintenance branches label Mar 14, 2024
@rwinch
Copy link
Member

rwinch commented Mar 14, 2024 •
edited
Loading

You can configure on.push.<branches|tags|branches-ignore|tags-ignore> in deploy-docs.yml in each branch to specify which branches/tags the docs will be built on.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 14, 2024
@snicoll snicoll modified the milestones: 6.1.x, 6.1.6 Mar 14, 2024
snicoll added a commit that referenced this issue Mar 14, 2024
@snicoll
Polish "Only include production branches for docs deployment"
7357812 
See gh-32434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
status: feedback-provided Feedback has been provided type: task A general task
Projects
None yet
Milestone
6.1.6
Development

No branches or pull requests
3 participants
@rwinch @snicoll @spring-projects-issues