Skip to content

Reorganize HTTP Observation types #29334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Oct 17, 2022 · 0 comments
Closed

Reorganize HTTP Observation types #29334

bclozel opened this issue Oct 17, 2022 · 0 comments
Assignees
Labels
theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Oct 17, 2022

#29324 started a discussion in the team and we decided to reorganize and rename types in the HTTP Observation support.
The work being done in spring-projects/spring-graphql#501 (where several observations are created with a single instrumentation) also influenced the changes in this issue.

While being quite late in the release cycle, all observation classes are new as of 6.0 and we think that getting the package structure right is worth the disruption.

In summary, we'd like to:

  • name the instrumentation classes with the space they're creating observations for. So HttpRequestsObservationFilter becomes ServerHttpObservationFilter. (same for other variants, client/server and servlet/reactive)
  • name the convention and context classes with the observation name, avoid plurals. so HttpRequestsObservationConvention becomes HttpRequestObservationConvention
  • move the base server observation classes from org.springframework.web.observation to org.springframework.http.observation, and the filters to org.springframework.web.filter
  • remove HttpOutcome entirely and move specific bits as package private implementation
@bclozel bclozel added type: enhancement A general enhancement theme: observability An issue related to observability and tracing labels Oct 17, 2022
@bclozel bclozel added this to the 6.0.0-RC2 milestone Oct 17, 2022
@bclozel bclozel self-assigned this Oct 17, 2022
bclozel added a commit to spring-projects/spring-boot that referenced this issue Oct 17, 2022
This commit adapts to the renames/package changes in the HTTP
Observation support in Spring Framework.

See spring-projects/spring-framework#29334
izeye added a commit to izeye/spring-framework that referenced this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant