Skip to content

Deprecate ignoreDefaultModelOnRedirect property and set to true by default #28324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Apr 11, 2022 · 1 comment
Closed

Deprecate ignoreDefaultModelOnRedirect property and set to true by default #28324

rstoyanchev opened this issue Apr 11, 2022 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@rstoyanchev
Copy link
Contributor

It's been a long time since this API and available options have been considered, and as per the discussion under #28069, we should review for potential changes towards 6.0.

One option would be to provide a Rendering API that aligns with what is available in WebFlux.

In the very least, we can deprecate the ignoreDefaultModelOnRedirect option on RequestMappingHandlerAdapter and change its default setting.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Apr 11, 2022
@rstoyanchev rstoyanchev added this to the 6.0.0-M4 milestone Apr 11, 2022
@rstoyanchev rstoyanchev self-assigned this Apr 11, 2022
@rstoyanchev rstoyanchev mentioned this issue Apr 11, 2022
Closed
@rstoyanchev rstoyanchev modified the milestones: 6.0.0-M4, 6.0.0-M5 May 11, 2022
@rstoyanchev rstoyanchev modified the milestones: 6.0.0-M5, 6.0.0-M6 Jul 13, 2022
@rstoyanchev rstoyanchev changed the title Review "default" vs redirect model default settings and API Deprecate ignoreDefaultModelOnRedirect property and set to true by default Sep 14, 2022
@rstoyanchev
Copy link
Contributor Author

The property is now deprecated and set to true by default. This also matches default settings in Boot.

@philwebb philwebb mentioned this issue Sep 14, 2022
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 20, 2022
@sbrannen
Remove unused variable in test
f140464 
See spring-projectsgh-28324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
1 participant
@rstoyanchev