Update DefaultExcerptProjector.java #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it does not exist an xcerptProjection, the object metadata.getExcerptProjection() return Optional.empty(), so that the metadata.getExcerptProjection() != null check is always true
|
@ravenberserk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ravenberserk Thank you for signing the Contributor License Agreement! |
odrotbohm
pushed a commit
that referenced
this pull request
Oct 28, 2019
…ection if metadata returns Optional.empty(). If no excerpt projection is exposed by the underlying ResourceMetadata, DefaultExcerptProjector now also properly declines its existence in ….hasExcerptProjection(…). Previously, it always indicated a presence as it improperly used a null check rather than calling Optional.isPresent(). Original pull request: #366.
odrotbohm
added a commit
that referenced
this pull request
Oct 28, 2019
Test cases. Original pull request: #366.
odrotbohm
pushed a commit
that referenced
this pull request
Oct 28, 2019
…ection if metadata returns Optional.empty(). If no excerpt projection is exposed by the underlying ResourceMetadata, DefaultExcerptProjector now also properly declines its existence in ….hasExcerptProjection(…). Previously, it always indicated a presence as it improperly used a null check rather than calling Optional.isPresent(). Original pull request: #366.
odrotbohm
added a commit
that referenced
this pull request
Oct 28, 2019
Test cases. Original pull request: #366.
|
That's polished and merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it does not exist an xcerptProjection, the object metadata.getExcerptProjection() return Optional.empty(), so that the metadata.getExcerptProjection() != null check is always true