Skip to content

DATAREST-1012 - added test to reproduce issue DATAREST-1012, fix Domain… #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

stefanreichert
Copy link

Hey guys,

I implemented a Unit Test to reproduce the error observed (see DomainObjectReaderTest) as well as a fix for the DomainObjectReader. Feedback is welcome, accepting the pull request even more ;)

Thanks for your great work, best regards,
Stefan

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

…ObjectReader to handle polymorphic persistent nested collections
…ObjectReader to handle polymorphic persistent nested collections
@odrotbohm
Copy link
Member

Would you mind squashing the commits and coming up with a commit message that actually describes the effect of the changes you made. From looking at the code I can see some grouping of collection items by type that definitely needs explanation.

Also, see more general comments on the ticket.

@stefanreichert
Copy link
Author

The change basically sticks to the existing implementation but considers the runtime type of the object to be merged to avoid the 'incompatibility' error. I'll squash the two commits and add a decent message. Thanks for your feedback!

@stefanreichert
Copy link
Author

OK, this PR is outdated so I'll withdraw it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants