Skip to content

DATAREST-965 Create tests to show issue were PUT is not clearing out nested properties #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DATAREST-965 Create tests to show issue were PUT is not clearing out nested properties #247

wants to merge 2 commits into from

Conversation

kdombeck
Copy link
Contributor

Currently this is just a test case and not an actual fix.

Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
Make sure that:

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
  • You provide your full name and an email address registered with your GitHub account. If you’re a first-time submitter, make sure you have completed the Contributor’s License Agreement form.

odrotbohm added a commit that referenced this pull request Jan 23, 2017
@odrotbohm
DATAREST-965 - Switched to property based application of PUT requests.
e7077cd 
Jacksons ObjectMapper.readerForUpdate(…) unfortunately doesn't handle nested objects properly. We already have a manual merge process in place for PATCH requests but tweaking that to also handle PUT requests gracefully caused more complexity than anticipated.

We now switched to an object based merge so that we can read in the source JSON structure into a new object and then merge the objects.

Related pull request: #247.
odrotbohm added a commit that referenced this pull request Jan 23, 2017
@odrotbohm
DATAREST-965 - Switched to property based application of PUT requests.
132807c 
Jacksons ObjectMapper.readerForUpdate(…) unfortunately doesn't handle nested objects properly. We already have a manual merge process in place for PATCH requests but tweaking that to also handle PUT requests gracefully caused more complexity than anticipated.

We now switched to an object based merge so that we can read in the source JSON structure into a new object and then merge the objects.

Related pull request: #247.
odrotbohm added a commit that referenced this pull request Jan 23, 2017
@odrotbohm
DATAREST-965 - Switched to property based application of PUT requests.
08f012d 
Jacksons ObjectMapper.readerForUpdate(…) unfortunately doesn't handle nested objects properly. We already have a manual merge process in place for PATCH requests but tweaking that to also handle PUT requests gracefully caused more complexity than anticipated.

We now switched to an object based merge so that we can read in the source JSON structure into a new object and then merge the objects.

Related pull request: #247.
@kdombeck kdombeck closed this Mar 3, 2017
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kdombeck