Support for Dialect specific custom conversions and OffsetDateTime. #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialects may now register a list of converters to take into consideration when reading or writing properties. See `JdbcSqlServerDialect` for an example. By default `OffsetDateTime` does not get converted anymore. If a database needs a conversion it can register it by implementing `Dialect.getConverters()` as described above. Closes #935
Removes superfluous method.
mp911de
reviewed
May 19, 2021
| @@ -96,8 +101,22 @@ public JdbcConverter jdbcConverter(JdbcMappingContext mappingContext, NamedParam | |||
| * @return will never be {@literal null}. | |||
| */ | |||
| @Bean | |||
| public JdbcCustomConversions jdbcCustomConversions() { | |||
| return new JdbcCustomConversions(); | |||
| public JdbcCustomConversions jdbcCustomConversions(Dialect dialect) { | |||
There was a problem hiding this comment.
A potential way out could be injecting ApplicationContext into this class making it ApplicationContextAware and handle the lookup through context.getBean(…).
mp911de
reviewed
May 19, 2021
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Nit: Something's off with formatting here.
There was a problem hiding this comment.
What exactly? I double checked my configuration, and don't see the mistake.
mp911de
reviewed
May 19, 2021
| * | ||
| * @return a collection of converters for this dialect. | ||
| */ | ||
| default Collection<Object> getConverters() { |
mp911de
reviewed
May 19, 2021
| * @since 2.3 | ||
| */ | ||
| @ReadingConverter | ||
| enum Timestamp2OffsetDateTimeConverter implements Converter<Timestamp, OffsetDateTime> { |
There was a problem hiding this comment.
How about TimestampAtUtcToOffsetDateTimeConverter to make it more descriptive than Timestamp2.
| * @since 2.3 | ||
| */ | ||
| @WritingConverter | ||
| enum OffsetDateTime2TimestampConverter implements Converter<OffsetDateTime, Timestamp> { |
There was a problem hiding this comment.
OffsetDateTimeToTimestampConverter
| import org.springframework.data.relational.core.dialect.SqlServerDialect; | ||
|
|
||
| /** | ||
| * {@link Db2Dialect} that registers JDBC specific converters. |
| } | ||
|
|
||
| @ReadingConverter | ||
| enum DateTimeOffset2OffsetDateTimeConverter implements Converter<DateTimeOffset, OffsetDateTime> { |
There was a problem hiding this comment.
DateTimeOffsetToOffsetDateTimeConverter
| } | ||
|
|
||
| @WritingConverter | ||
| enum OffsetDateTime2TimestampJdbcValueConverter implements Converter<OffsetDateTime, JdbcValue> { |
There was a problem hiding this comment.
OffsetDateTimeToJdbcValueConverter
| } | ||
|
|
||
| @ReadingConverter | ||
| enum TimestampWithTimeZone2OffsetDateTimeConverter implements Converter<TimestampWithTimeZone, OffsetDateTime> { |
There was a problem hiding this comment.
TimestampWithTimeZoneToOffsetDateTimeConverter
| @Override | ||
| public Collection<Object> getConverters() { | ||
|
|
||
| ArrayList<Object> converters = new ArrayList<>(super.getConverters()); |
There was a problem hiding this comment.
Nit: List<Object> instead of ArrayList
| import static org.assertj.core.api.Assertions.*; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| /* |
Dialects now can define a set of known simple types the driver can handle without further interaction. This is done to avoid warnings during converter registration for types known in one environment but not the other. Also move types around a bit, change visibility and make sure jdbc specific dialects inherit converters from their parents.
schauder
added a commit
that referenced
this pull request
May 31, 2021
Dialects may now register a list of converters to take into consideration when reading or writing properties. See `JdbcSqlServerDialect` for an example. By default `OffsetDateTime` does not get converted anymore. If a database needs a conversion it can register it by implementing `Dialect.getConverters()` as described above. Closes #935 Original pull request #981
schauder
pushed a commit
that referenced
this pull request
May 31, 2021
Dialects now can define a set of known simple types the driver can handle without further interaction. This is done to avoid warnings during converter registration for types known in one environment but not the other. Also move types around a bit, change visibility and make sure jdbc specific dialects inherit converters from their parents. Original pull request #981 See #935
|
That's merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialects may now register a list of converters to take into consideration when reading or writing properties.
See
JdbcSqlServerDialectfor an example.By default
OffsetDateTimedoes not get converted anymore.If a database needs a conversion it can register it by implementing
Dialect.getConverters()as described above.Closes #935