Map boolean values to 0 or 1 if dialect is SqlServerDialect. #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
schauder
requested changes
Mar 11, 2021
| @@ -402,10 +403,16 @@ private Condition createCondition(Column column, @Nullable Object mappedValue, i | |||
| } | |||
|
|
|||
| if (comparator == Comparator.IS_TRUE) { | |||
| if (dialect instanceof SqlServerDialect) { | |||
There was a problem hiding this comment.
Anything that is database specific needs to go into the Dialect. Instanceof checks for the Dialect implementation are a hard no-go.
I'm wondering if a better way to handle this is to register a converter for booleans that we then apply to the value.
There was a problem hiding this comment.
I will introduce a new default method at Dialect interface to handle boolean values.
…SqlServer dialect. Signed-off-by: Manousos Mathioudakis <[email protected]>
|
We discussed this internally and decided not to go with this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #908