DATAJDBC-479 - Use SqlIdentifier in SQL AST #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use SqlIdentifier to encapsulate names and aliases of tables, columns and functions.
We now use proper delegation to ConditionVisitor to render a JOIN condition. Previously, we used toString() of Condition segments which rendered an approximation of the condition. ConditionVisitor applies RenderContext settings that consider identifier quoting and normalization strategies.
schauder
reviewed
Jan 29, 2020
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGenerator.java
Outdated
Show resolved
Hide resolved
|
|
||
| private AliasedColumn(String name, Table table, String alias) { | ||
| super(name, table); | ||
| this.alias = SqlIdentifier.unquoted(alias); |
There was a problem hiding this comment.
Isn't this a little inconsistent, since we want to go to "always quoted" as the default otherwise?
There was a problem hiding this comment.
We're preserving the current functionality. Our quoting can be enabled or disabled on PersistentEntity level which is a different abstraction level. Since we're creating our SQL AST objects from these types, it's fair to not put the always quoting burden on every user of the SQL AST. You can always opt in with using SqlIdentifier on the consumer side if you're willing to control how identifiers are rendered.
...ational/src/main/java/org/springframework/data/relational/core/sql/DefaultSqlIdentifier.java
Outdated
Show resolved
Hide resolved
SqlIdentifiers are now compared by considering case-sensitivity regardless of quoting.
2 tasks
schauder
pushed a commit
that referenced
this pull request
Feb 11, 2020
We now use SqlIdentifier to encapsulate names and aliases of tables, columns and functions. We now use proper delegation to ConditionVisitor to render a JOIN condition. Previously, we used toString() of Condition segments which rendered an approximation of the condition. ConditionVisitor applies RenderContext settings that consider identifier quoting and normalization strategies. Original pull request: #187.
schauder
added a commit
that referenced
this pull request
Feb 11, 2020
Fixes compiler error from rebase rebase. Removes IdentifierProcessingAdapter since it wasn't used anymore Merged UnquotedDialect with NonQuotingDialect since both served the same purpose of a simple Dialect for testing. Formatting. Original pull request: #187.
|
Rebased, polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use
SqlIdentifierto encapsulate names and aliases of tables, columns and functions.This change also introduces proper delegation to ConditionVisitor to render a
JOINcondition. Previously, we usedtoString()ofConditionsegments which rendered an approximation of the condition.ConditionVisitorappliesRenderContextsettings that consider identifier quoting and normalization strategies.Related ticket: DATAJDBC-479.