Issue1502/root whitout id exception #1843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, if I need to adjust anything in the PR, please let me know. I tried to follow the contributor guide as closely as possible. |
schauder
requested changes
Aug 2, 2024
There was a problem hiding this comment.
I don't see how this fixes the issue.
The problem we want to resolve is that we want two different exceptions:
- One exception when the id of an entity with id wasn't set to a non-null value. We already get this. And your PR slightly changes the exception, but changes it under the same circumstances.
- A different exception when the entity doesn't have an id at all that could be checked for being
null.
You can as a PersistentEntity for its id property and check if that is null for this test.
| @@ -447,11 +449,6 @@ private <T> void doDeleteAll(Iterable<? extends T> instances, Class<T> domainTyp | |||
|
|
|||
| private <T> T afterExecute(AggregateChange<T> change, T entityAfterExecution) { | |||
|
|
|||
| Object identifier = context.getRequiredPersistentEntity(change.getEntityType()) | |||
There was a problem hiding this comment.
I don't see the need to extract the check out of this method.
|
Superseded by #1855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1502 fix when agregate root are whitout id. Add exception