Allow passing of tuples to methods #1838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1569 seems related. |
mp911de
reviewed
Jul 22, 2024
| @@ -204,23 +207,47 @@ private void convertAndAddParameter(MapSqlParameterSource parameters, Parameter | |||
| TypeInformation<?> typeInformation = parameter.getTypeInformation(); | |||
|
|
|||
| JdbcValue jdbcValue; | |||
| if (typeInformation.isCollectionLike() && value instanceof Collection<?>) { | |||
| if (typeInformation.isCollectionLike() // | |||
There was a problem hiding this comment.
We should make our concepts more explicit. Binding a single value is fine. Binding a List should become more explicit what we're up to. Binding a list of elements would result in parameter expansion while binding a list of arrays results in tuple expansion.
I suggest that we refactor the code a bit into a form that we extract methods and prepare the target types (i.e. actual type) so that we have a more explicit flow.
Let me know what you think.
There was a problem hiding this comment.
I'm happy with that.
Are you thinking refactoring in the strict sense, i.e. we keep the behaviour as it is with this PR?
Refactor convertAndAddParameter method to writeValue(…) decoupling responsibilities for a clearer value conversion code path. Also, refactor collection conversion to functional callback-style and extend test assertions.
mp911de
added
type: regression
|
That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1323
To be honest, I'm not sure if this is the right way to fix this. Could you take a hard critical look, please?