Fix usage of wrong id value in related selects #1810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an aggregate A->B-Collection<C> a select gets executed for loading Collection<C>. That select used the wrong ID when B had an ID with the same name as A. This is now fixed. Closes #1802
|
This is an important fix for us @ma10s - in order to upgrade https://github.com/navikt/familie-tilbake/ Fixing our issue with the relations |
charliemidtlyng
approved these changes
Jun 10, 2024
mp911de
reviewed
Jun 10, 2024
| @@ -467,6 +467,20 @@ void getEffectiveIdColumnName() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test // GH-1802 | |||
| void dingens() { | |||
There was a problem hiding this comment.
Oops, sorry. I thought gave that thing a proper name 😢
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an aggregate A->B-Collection a select gets executed for loading Collection.
That select used the wrong ID when B had an ID with the same name as A.
This is now fixed.
Closes #1802