Skip to content

Fix loading of 2nd level collections #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix loading of 2nd level collections #1773

wants to merge 2 commits into from

Conversation

schauder
Copy link
Contributor

Construction of the back reference assumed that the table holding the parent of the foreign key is the actual parent property.
This is now corrected by using the correct API to identify the ancestor which holds the id.

Closes: #1692

schauder added 2 commits April 16, 2024 16:18
@schauder
1692-collection-in-embedded - Prepare branch
dfd87a9
@schauder
Fix loading of 2nd level collections.
4e16b05 
Construction of the backreference assumed that the table holding the parent of the foreign key is the actual parent property.
This is now corrected by using the correct API to identify the ancestor which holds the id.

Closes: #1692
@schauder schauder requested a review from mp911de April 17, 2024 07:28
This was referenced Apr 17, 2024
Closed
Closed
Closed
charliemidtlyng
charliemidtlyng approved these changes Apr 17, 2024
View reviewed changes
Copy link

@charliemidtlyng charliemidtlyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to run our system against this PR and it seems to be good. ✅ 👏

Would it be nice to create an integrationtest for this purpose?

DummyA -> DummyB -> ListOf(DummyC)

@mp911de mp911de added the type: regression A regression from a previous release label Apr 18, 2024
@mp911de mp911de changed the title Fix loading of 2nd level collections. Fix loading of 2nd level collections Apr 18, 2024
schauder added a commit that referenced this pull request Apr 18, 2024
@schauder
Fix loading of 2nd level collections.
30e4ddd 
Construction of the back reference assumed that the table holding the parent of the foreign key is the actual parent property.
This is now corrected by using the correct API to identify the ancestor which holds the id.

Closes: #1692
Original pull request: #1773
schauder added a commit that referenced this pull request Apr 18, 2024
@schauder
Fix loading of 2nd level collections.
b22ccad 
Construction of the back reference assumed that the table holding the parent of the foreign key is the actual parent property.
This is now corrected by using the correct API to identify the ancestor which holds the id.

Closes: #1692
Original pull request: #1773
@schauder
Copy link
Contributor Author

Merged and back ported to 3.2.x

@schauder schauder closed this Apr 18, 2024
@schauder schauder self-assigned this Apr 18, 2024
@mp911de mp911de deleted the issue/1692-collection-in-embedded branch April 18, 2024 09:22
@schauder schauder added this to the 3.2.6 (2023.1.6) milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliemidtlyng charliemidtlyng charliemidtlyng approved these changes

@mp911de mp911de mp911de approved these changes

Assignees

@schauder schauder

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.2.6 (2023.1.6)
Development

Successfully merging this pull request may close these issues.

Spring Data JDBC @Embedded entity with @MappedCollection
3 participants
@schauder @charliemidtlyng @mp911de