DATAJDBC-437 - In strict mode we only claim repositories for domain types with @Table annotation.
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes with @table annotation. Before this change Spring Data JDBC didn't specify any identifying annotation and therefore would claim all or no repository depending on the the version of Spring Data Commons. Also added the RepositoryFactorySupport to spring.factory in order to support detection of multiple RepositoryFactorySupport implementations on the classpath. See also: https://jira.spring.io/browse/DATACMNS-1596.
mp911de
requested changes
Oct 24, 2019
| @@ -56,7 +58,8 @@ | |||
|
|
|||
| @Configuration | |||
| @Import(TestConfiguration.class) | |||
| @EnableJdbcRepositories(considerNestedRepositories = true) | |||
| @EnableJdbcRepositories(includeFilters = @Filter(type = FilterType.REGEX, | |||
There was a problem hiding this comment.
We should improve handling for non-existent entity types in JdbcRepositoryFactory.getTargetRepository(…) (e.g. calling getRequiredPersistentEntity(…) instead of getPersistentEntity(…)).
java.lang.IllegalArgumentException: entity is marked non-null but is null
at org.springframework.data.jdbc.repository.support.SimpleJdbcRepository.<init>(SimpleJdbcRepository.java:36)
is hard to debug.
| * Unit tests for {@link JdbcRepositoryConfigExtension}. | ||
| * | ||
| * @author Jens Schauder | ||
| * @since 1.2 |
There was a problem hiding this comment.
Nit: No need for @since in test classes.
There was a problem hiding this comment.
|
|
||
| interface SampleRepository extends Repository<Sample, Long> {} | ||
|
|
||
| interface UnannotatedRepository extends Repository<Object, Long> {} |
There was a problem hiding this comment.
Ideally, we don't use Object here to avoid the need to touch other, unrelated tests. Let's use a different type here.
The repository for an unannotated entity now can be constructed, avoiding the need to exclude it in other tests. Improved error message for failure to create a repository by using `getRequiredPersistentEntity`. Removed superfluous `@since` annotation.
|
I implemented the suggested improvements. |
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
…ypes with @table annotation. Before this change Spring Data JDBC didn't specify any identifying annotation and therefore would claim all or no repository depending on the the version of Spring Data Commons. Also added the RepositoryFactorySupport to spring.factory in order to support detection of multiple RepositoryFactorySupport implementations on the classpath. Related ticket: DATACMNS-1596. Original pull request: #177.
mp911de
added a commit
that referenced
this pull request
Oct 25, 2019
Remove unused imports. Original pull request: #177.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
…ypes with @table annotation. Before this change Spring Data JDBC didn't specify any identifying annotation and therefore would claim all or no repository depending on the the version of Spring Data Commons. Also added the RepositoryFactorySupport to spring.factory in order to support detection of multiple RepositoryFactorySupport implementations on the classpath. Related ticket: DATACMNS-1596. Original pull request: #177.
mp911de
added a commit
that referenced
this pull request
Oct 25, 2019
Remove unused imports. Original pull request: #177.
|
That's merged, polished, and backported now. |
schauder
added a commit
that referenced
this pull request
Oct 29, 2019
…ypes with @table annotation. Before this change Spring Data JDBC didn't specify any identifying annotation and therefore would claim all or no repository depending on the the version of Spring Data Commons. Also added the RepositoryFactorySupport to spring.factory in order to support detection of multiple RepositoryFactorySupport implementations on the classpath. Related ticket: DATACMNS-1596. Original pull request: #177.
schauder
pushed a commit
that referenced
this pull request
Oct 29, 2019
Remove unused imports. Original pull request: #177.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change Spring Data JDBC didn't specify any identifying annotation and therefore would claim all or no repository depending on the the version of Spring Data Commons.
Also added the RepositoryFactorySupport to spring.factory in order to support detection of multiple RepositoryFactorySupport implementations on the classpath.
See also: https://jira.spring.io/browse/DATACMNS-1596.
Original issue: https://jira.spring.io/browse/DATAJDBC-437.