DATAJDBC-431 - ReadOnlyProperty now gets properly handled. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that the SqlGenerator honored the annotation but they were included as query parameters and therefore automatically added back again. Also: * Simplified the relevant filter in the SqlGenerator. * Introduced a meta annotation for running tests only agains HsqlDb.
Improved and corrected nullability annotations.
schauder
force-pushed
the
issue/DATAJDBC-431
branch
from
fa0607a to
f9700bf
Compare
mp911de
reviewed
Oct 24, 2019
| /** | ||
| * Run the annotated test only against a HsqlDb database. | ||
| * | ||
| * Requires the use of |
There was a problem hiding this comment.
Nit: Something is missing here.
There was a problem hiding this comment.
I added another commit completing the comment.
Fixed broken Javadoc.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
The problem was that the SqlGenerator honored the annotation but they were included as query parameters and therefore automatically added back again. Also: * Simplified the relevant filter in the SqlGenerator. * Introduced a meta annotation for running tests only agains HsqlDb. Original pull request: #175.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
Improved and corrected nullability annotations. Fixed broken Javadoc. Original pull request: #175.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
The problem was that the SqlGenerator honored the annotation but they were included as query parameters and therefore automatically added back again. Also: * Simplified the relevant filter in the SqlGenerator. * Introduced a meta annotation for running tests only agains HsqlDb. Original pull request: #175.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
Improved and corrected nullability annotations. Fixed broken Javadoc. Original pull request: #175.
|
That's merged, squashed, and backported now. |
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Edited the reference guide, checking for spelling, grammar, usage, punctuation, and corporate voice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the SqlGenerator honoured the annotation but they were included as query parameters and therefore automatically added back again.
Also simplified the relevant filter in the SqlGenerator.
Issue: https://jira.spring.io/browse/DATAJDBC-431