DATAJDBC-340 - Using new SQL generation DSL. #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SqlGenerator basically got rewritten using the new SQL rendering API. The SQL rendering API got some minor improvements in the process. The whole generation process is now based on paths instead of properties which makes the actual logic of the construciton much more obvious.
Encapsulate column caches in Columns type. Relax RelationalMappingContext to MappingContext with appropriate generics. Remove unused SQL generator source. Cache table and Id column objects. Simplify assertions. Consistently use naming pattern for named parameters. Migrate http URLs to https.
mp911de
force-pushed
the
issue/DATAJDBC-340
branch
from
f700cca to
5b73e40
Compare
mp911de
pushed a commit
that referenced
this pull request
Apr 9, 2019
SqlGenerator basically got rewritten using the new SQL rendering API. The SQL rendering API got some minor improvements in the process. The whole generation process is now based on paths instead of properties which makes the actual logic of the construction much more obvious. Original pull request: #147.
mp911de
added a commit
that referenced
this pull request
Apr 9, 2019
Encapsulate column caches in Columns type. Relax RelationalMappingContext to MappingContext with appropriate generics. Remove unused SQL generator source. Cache table and Id column objects. Simplify assertions. Consistently use naming pattern for named parameters. Migrate http URLs to https. Original pull request: #147.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlGenerator basically got rewritten using the new SQL rendering API.
The SQL rendering API got some minor improvements in the process.
The whole generation process is now based on paths instead of properties which makes the actual logic of the construction much more obvious.