Skip to content

Support readonly properties for references. #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

schauder
Copy link
Contributor

The @ReadOnlyProperty annotation is now honoured for references to entities or collections of entities.

For tables mapped to such annotated references, no insert, delete or update statements will be created.
The user has to maintain that data through some other means.
These could be triggers or external process or ON DELETE CASCADE configuration in the database schema.

Closes #1249

schauder added 3 commits May 18, 2022 09:59
The `@ReadOnlyProperty` annotation is now honoured for references to entities or collections of entities.

For tables mapped to such annotated references, no insert, delete or update statements will be created.
The user has to maintain that data through some other means.
These could be triggers or external process or `ON DELETE CASCADE` configuration in the database schema.

Closes #1249
Refactoring.

See #1249
@schauder schauder requested a review from gregturn May 19, 2022 08:06
Copy link
Contributor

@gregturn gregturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than the questions I posed.

schauder added a commit that referenced this pull request May 23, 2022
The `@ReadOnlyProperty` annotation is now honoured for references to entities or collections of entities.

For tables mapped to such annotated references, no insert, delete or update statements will be created.
The user has to maintain that data through some other means.
These could be triggers or external process or `ON DELETE CASCADE` configuration in the database schema.

Closes #1249
Original pull request #1250
schauder added a commit that referenced this pull request May 23, 2022
Refactoring and code aesthetics.

See #1249
Original pull request #1250
@schauder
Copy link
Contributor Author

Thanks for the review. Those things are fixed, and the complete change is merged to main.

@schauder schauder closed this May 23, 2022
@schauder schauder deleted the issue/1249-readonly-reference branch May 23, 2022 08:52
@schauder schauder self-assigned this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ReadOnlyProperty with child entity associated with a View possibly related to DATAJDBC-431
2 participants