Convert @Query method Iterable parameters like findBy* query methods #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
+ Copy logic from QueryMapper#convertToJdbcValue to resolve Iterable arguments on findBy* query methods to resolve the same for @query. + Use parameter ResolvableType instead of Class to retain generics info.
ctailor2
force-pushed
the
issue/1212-query-in-clause-with-enum
branch
from
ffadf48 to
8412774
Compare
|
Thanks, that's merged and backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently limited support for
@Querymethods withIterableparameters, which may be used, for example, in declaring a query with the SQLINoperator. For such parameters, the interpretation of the query and the supplied arguments works as expected as long as theIterableparameter generic type can be handled directly by the JDBC driver without conversion. If conversion is required, for example when usingIterable<Enum>, the method invocation fails as the driver cannot handleEnumtypes natively.These changes carry over the logic for conversion of
Iterablevalues fromQueryMapper#convertToJdbcValue, which is used to resolve parameters forfindBy*methods, intoStringBasedJdbcQueryto provide more complete support for such parameters in@Querymethods.Closes #1212