Fix inconsistency of JdbcAggregateTemplate#save return value. #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with immutably typed ids. + Added #getIdValueSource to DbAction.WithEntity since it now applies to all such DbAction. + Removed DbAction.WithGeneratedId in favor of DbAction.WithEntity where it was used.
spring-projects-issues
added
the
status: waiting-for-triage
ctailor2
force-pushed
the
issue/1201-update-return-value
branch
from
4ad17f5 to
5f25038
Compare
actions. + Isolate aggregate change #getEntity #setEntity behaviors into a new interface for "save" changes. + Extract #setEntity from DbAction.WithEntity to a new DbAction interface just for root actions. + JdbcAggregateChangeExecutionContext#populateIdsIfNecessary returns the root entity from DbAction.InsertRoot or DbAction.UpdateRoot regardless of the immutability of its @id property.
ctailor2
force-pushed
the
issue/1201-update-return-value
branch
from
5f25038 to
405b093
Compare
schauder
pushed a commit
that referenced
this pull request
Mar 29, 2022
…s with immutably typed ids. + Added #getIdValueSource to DbAction.WithEntity since it now applies to all such DbAction. + Removed DbAction.WithGeneratedId in favor of DbAction.WithEntity where it was used. Removes unused DbAction.Update. Passes the root from BeforeSaveCallback through to InsertRoot,UpdateRoot actions. + Isolate aggregate change #getEntity #setEntity behaviors into a new interface for "save" changes. + Extract #setEntity from DbAction.WithEntity to a new DbAction interface just for root actions. + JdbcAggregateChangeExecutionContext#populateIdsIfNecessary returns the root entity from DbAction.InsertRoot or DbAction.UpdateRoot regardless of the immutability of its @id property. Closes #1199 Closes #1201 Original pull request #1208
|
Thanks. That's polished and merged. I didn't backport it since it is breaking some (mostly internal, yet public) API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs that caused the return value of
JdbcAggregateTemplate#saveto be inconsistent with its API contract, under specific situations (see linked issues for more details).Closes #1199
Closes #1201