GH-1159 Batch Insert Operations Within a Single Aggregate #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
ctailor2
force-pushed
the
issue/1159-batch-insert-within-aggregate
branch
from
213a801 to
e5d6272
Compare
ctailor2
changed the title
schauder
reviewed
Mar 7, 2022
...-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BatchInsertStrategy.java
Show resolved
Hide resolved
schauder
reviewed
Mar 7, 2022
...data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlParametersFactory.java
Outdated
Show resolved
Hide resolved
schauder
requested changes
Mar 7, 2022
...data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlParametersFactory.java
Outdated
Show resolved
Hide resolved
...data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlParametersFactory.java
Outdated
Show resolved
Hide resolved
...data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlParametersFactory.java
Outdated
Show resolved
Hide resolved
...g-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DataAccessStrategy.java
Outdated
Show resolved
Hide resolved
...g-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DataAccessStrategy.java
Outdated
Show resolved
Hide resolved
ctailor2
commented
Mar 7, 2022
...g-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DataAccessStrategy.java
Outdated
Show resolved
Hide resolved
schauder
requested changes
Mar 11, 2022
There was a problem hiding this comment.
As for the old method signatures: They should behave as close to the original as possible. If they don't work for certain cases we need to identify those cases in order to decide if we can go forward with this, or if we have to move the change to the next major release.
...-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BatchJdbcOperations.java
Outdated
Show resolved
Hide resolved
...-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BatchJdbcOperations.java
Outdated
Show resolved
Hide resolved
...-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BatchJdbcOperations.java
Outdated
Show resolved
Hide resolved
...ces/org.springframework.data.jdbc.repository/JdbcRepositoryWithListsIntegrationTests-db2.sql
Show resolved
Hide resolved
|
And please squash the actual feature in a single commit ,please. |
I removed my previous default implementation for the deprecated |
ctailor2
force-pushed
the
issue/1159-batch-insert-within-aggregate
branch
from
370e08f to
295ac39
Compare
+ Group into batches when populating AggregateChange based on the presence/absence of a value for @id. + Add Dialect IdGeneration property to indicate support for batch operations. No support by SqlServer and DB2 Dialects.
ctailor2
force-pushed
the
issue/1159-batch-insert-within-aggregate
branch
from
295ac39 to
26904fc
Compare
|
Thanks, that's merged. |
schauder
added a commit
that referenced
this pull request
Sep 18, 2023
BatchJdbcOperations is still there, but deprecated, and not used except for deprecated places kept for backward compatibility. This is possible since Spring Framework made the features offered by `BatchJdbcOperations` part of `NamedParameterJdbcOperations`. See spring-projects/spring-framework#28132 See #1191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the strategy for inserting entities referenced by aggregate to perform a batch insert when there are multiple entities in a collection.
This is only possible for databases which support retrieving generated keys for batch operations through
Statement#getGeneratedKeys, which includes all currently supported databases other than DB2 and MS SQL Server. Note: DB2 does support this functionality outside of the JDBC spec withDB2PreparedStatement#getDBGeneratedKeys.This implementation includes low level code in
BatchJdbcOperationsfor performing the batch insert with aKeyHolderandString[] keyColumnNameswhich has largely been copied from spring frameworkspring-jdbc, pending the acceptance of a proposal to add native support via additionalNamedParameterJdbcOperations#batchUpdatemethods. If and when this proposal is accepted and merged,BatchJdbcOperationscan be deleted and callers into it can be replaced with calls intoNamedParameterJdbcOperations.Caveats:
AggregateChangeto be executed, inserts for a given referenced collection of entities are grouped into batches based on the presence/absence of an id value. Since this is determined only once rather than with every jdbc operation, this will produce unexpected results for any existingBeforeSaveCallbackthat is setting the value of an@Idannotated property. Any such operation will need to be moved toBeforeConvertCallbackin order to continue working as expected.MyBatisDataAccessStrategyat this time. When used, this will process the batch insert as serial inserts.Closes #1159